Marek Kasik [Mon, 14 Jul 2014 15:02:13 +0000 (17:02 +0200)]
Remove redundant checks for NULL
Remove checks for NULL before g_free() and g_clear_object().
Merge check for NULL, freeing of pointer and its setting
to NULL by g_clear_pointer().
https://bugzilla.gnome.org/show_bug.cgi?id=733157
Matthias Clasen [Thu, 2 Oct 2014 04:37:52 +0000 (00:37 -0400)]
GtkCellRendererAccel: Stop using deprecated API
Matthias Clasen [Thu, 2 Oct 2014 04:30:52 +0000 (00:30 -0400)]
GtkFontChooserWidget: Stop using deprecated API
Matthias Clasen [Thu, 2 Oct 2014 04:19:08 +0000 (00:19 -0400)]
GtkColorEditor: Fix missing background in popups
Matthias Clasen [Thu, 2 Oct 2014 04:11:02 +0000 (00:11 -0400)]
GtkColorEditor: Stop using deprecated API
This call was not needed at all.
Matthias Clasen [Thu, 2 Oct 2014 04:05:43 +0000 (00:05 -0400)]
GtkFontButton: Stop using deprecated API
Matthias Clasen [Thu, 2 Oct 2014 02:45:30 +0000 (22:45 -0400)]
GtkSidebar: not a listbox anymore
Applications are not expected to call GtkListBox API on a
sidebar, so don't make it one. Instead, make it have a
listbox.
Matthias Clasen [Thu, 2 Oct 2014 00:09:10 +0000 (20:09 -0400)]
GtkCalendar: deal better with a large allocation
When allocated more than the requested height, GtkCalendar
was 'falling apart'. Not only was the main part rendered
at the far end of the allocation, clicking on days was
broken in this scenario.
Fix this by always placing the main part directly under
the header and day names.
https://bugzilla.gnome.org/show_bug.cgi?id=737670
Matthias Clasen [Wed, 1 Oct 2014 23:52:04 +0000 (19:52 -0400)]
Trivial formatting fix
Matthias Clasen [Wed, 1 Oct 2014 23:30:12 +0000 (19:30 -0400)]
Fix a typo
Matthias Clasen [Wed, 1 Oct 2014 17:17:14 +0000 (13:17 -0400)]
Don't emit a useless warning
The warning may have had some value at some point, but if
people uninstall large icons just to make the warning go
away, it does more harm than good. So just remove it.
Matthias Clasen [Wed, 1 Oct 2014 11:11:43 +0000 (07:11 -0400)]
Fix fonts in context menus
Context menus inherit their style from the widget they are attached
to. This can have unexpected effects in particular for font, as can
be seen in gedit or gnome-calculator. Prevent this by resetting
the font of context-menus to the initial value.
Matthias Clasen [Wed, 1 Oct 2014 04:50:25 +0000 (00:50 -0400)]
Avoid compiler warnings
Matthias Clasen [Wed, 1 Oct 2014 04:49:59 +0000 (00:49 -0400)]
Add a few missing include guards
Matthias Clasen [Wed, 1 Oct 2014 04:45:23 +0000 (00:45 -0400)]
Provisional sidebar theming
needs-attention is not handled yet, here.
Ikey Doherty [Sat, 23 Aug 2014 16:38:42 +0000 (17:38 +0100)]
Add GtkSidebar
GtkSidebar behaves internally much like GtkStackSwitcher, providing a vertical
sidebar like widget. It is virtually identical in appearance to the widget
currently used in GNOME Tweak Tool.
This widget is connected to a GtkStack, and builds its own contents as a
GtkListBox subclass, using the "title" child property to provide a consistent
navigatable widget.
Being a subclass of GtkListBox it benefits immediately from strong keyboard
navigation, and minimal changes are required for theming.
https://bugzilla.gnome.org/show_bug.cgi?id=735293
Signed-off-by: Ikey Doherty <michael.i.doherty@intel.com>
Jasper St. Pierre [Tue, 30 Sep 2014 18:37:26 +0000 (12:37 -0600)]
reftests: Actually add a text-shadow to the text-shadow reftest
The reftest still passes, since the code still works, but we might as
well test what we claim to test.
Jasper St. Pierre [Tue, 30 Sep 2014 18:32:47 +0000 (12:32 -0600)]
label: Don't add in the allocation to our clip again
_gtk_widget_set_simple_clip already takes the allocation into account,
so we don't need to do it here.
Alexandre Franke [Tue, 30 Sep 2014 17:50:27 +0000 (17:50 +0000)]
Updated French translation
GNOME Translation Robot [Tue, 30 Sep 2014 13:01:46 +0000 (13:01 +0000)]
Updated Scottish Gaelic translation
Marek Černocký [Tue, 30 Sep 2014 11:27:20 +0000 (13:27 +0200)]
Updated Czech translation
Marek Černocký [Tue, 30 Sep 2014 11:27:14 +0000 (13:27 +0200)]
Updated Czech translation
Yosef Or Boczko [Tue, 30 Sep 2014 10:58:17 +0000 (13:58 +0300)]
Updated Hebrew translation
Chun-wei Fan [Tue, 30 Sep 2014 05:00:32 +0000 (13:00 +0800)]
Update README.txt for MSVC Builds
Tell people that they need to download and install the Adwaita icon theme,
by following the instructions given on
https://live.gnome.org/GTK%2B/Win32/MSVCCompilationOfGTKStack.
Also tell people they can either use IJG JPEG or libjpeg-turbo for non-GDI+
builds of GDK-Pixbuf.
Matthias Clasen [Tue, 30 Sep 2014 04:55:03 +0000 (00:55 -0400)]
Better typography for ppd paper names
These often contain a <num>x<num> string, which we can display
nicer by rendering it as <num>×<num>.
Matthias Clasen [Tue, 30 Sep 2014 04:07:22 +0000 (00:07 -0400)]
Deprecate GtkWidget override APIs
This is better done with css and style classes nowadays.
Matthias Clasen [Tue, 30 Sep 2014 04:03:25 +0000 (00:03 -0400)]
Add 3.16 deprecation macros too
Matthias Clasen [Sat, 27 Sep 2014 04:20:50 +0000 (00:20 -0400)]
GtkContainer: Support focus chain in GtkBuilder
This adds support for a <focus-chain> element which can be
used to specify a custom focus order for the children of
a container.
https://bugzilla.gnome.org/show_bug.cgi?id=582799
Matthias Clasen [Tue, 30 Sep 2014 03:55:13 +0000 (23:55 -0400)]
GtkButton: Use GtkLabel:xalign
Matthias Clasen [Tue, 30 Sep 2014 03:44:46 +0000 (23:44 -0400)]
GtkAssistant: Use GtkLabel:xalign
Matthias Clasen [Tue, 30 Sep 2014 03:54:13 +0000 (23:54 -0400)]
Keep GtkMisc:xalign working for labels
Set the new label properties when gtk_misc_set_alignment is used,
to keep things working.
Matthias Clasen [Tue, 30 Sep 2014 03:27:38 +0000 (23:27 -0400)]
Revert "Undreprecate GtkMisc::x/yalign for now"
This reverts commit
29eae57be4d864de6868cc229b18d801dd67ee8e.
We have GtkLabel:xalign now, so deprecate the GtkMisc property again.
Matthias Clasen [Tue, 16 Sep 2014 03:17:11 +0000 (23:17 -0400)]
GtkLabel: add x/yalign properties
Since it turns out that x/yalign can't be quite equivalently
replaced by h/valign, bring them back as label properties, so
we can eventually get rid of GtkMisc.
https://bugzilla.gnome.org/show_bug.cgi?id=735841
Matthias Clasen [Tue, 30 Sep 2014 03:33:33 +0000 (23:33 -0400)]
Add 3.16 version macros
Matthias Clasen [Fri, 22 Aug 2014 15:10:39 +0000 (11:10 -0400)]
printing: Better typography
Use U+201C/U+201D for quoting.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:10:03 +0000 (11:10 -0400)]
printing: Better typography
Use U+2013 for ranges.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:09:21 +0000 (11:09 -0400)]
inspector: Better typography
Use U+201C/U+201D for quoting.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:08:52 +0000 (11:08 -0400)]
GtkRecentChooserMenu: Better typography
Avoid `' quoting.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:07:41 +0000 (11:07 -0400)]
GtkPlacesSidebar: Be consistent in messages
Always quote drive/volume names.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:07:13 +0000 (11:07 -0400)]
GtkFileChooserWidget: Better typography
No double space after .
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:06:47 +0000 (11:06 -0400)]
GtkVolumeButton: Better typography
Use a small space before %. This matches what we do for percentages
elsewhere.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:06:08 +0000 (11:06 -0400)]
GtkProgressBar: Mark the default text for translation
At the same time, use a small space before %.
This matches what is done in GtkCellRendererProgress.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:05:20 +0000 (11:05 -0400)]
Progress widgets: Better typography
Use a small space before %.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:04:07 +0000 (11:04 -0400)]
GtkBuilder: Improve error messages
No `' looks just terrible. For quoting in non-UI contexts, we
prefer either '' or "".
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:03:07 +0000 (11:03 -0400)]
GtkColorSelection: Better typography
Use U+201C/U+201D for quoting, and use U+2019 instead of apostrophe.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 15:02:31 +0000 (11:02 -0400)]
Broadway: Improve formatting of an error message
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 14:15:44 +0000 (10:15 -0400)]
Printing: Better typography
Use U+007D MULTPLICATION SIGN for dimensions.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Fri, 22 Aug 2014 14:06:49 +0000 (10:06 -0400)]
GtkPrintUnixDialog: Better typography
Use U+2236 RATIO instead of ':' for times.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Thu, 21 Aug 2014 21:03:00 +0000 (17:03 -0400)]
Use better typography for paper names
Use U+00D7 MULTIPLICATION SIGN instead of a plain old x in
paper names, following https://wiki.gnome.org/Design/OS/Typography.
This is a string change.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
Matthias Clasen [Tue, 30 Sep 2014 02:14:49 +0000 (22:14 -0400)]
Bump version
Matthias Clasen [Tue, 30 Sep 2014 01:37:36 +0000 (21:37 -0400)]
3.14.1
Matthias Clasen [Tue, 30 Sep 2014 01:28:25 +0000 (21:28 -0400)]
Update file lists
We were forgetting to include some theme files.
Jesse van den Kieboom [Sat, 23 Aug 2014 08:59:29 +0000 (10:59 +0200)]
quartz: Add availability check for >= 10.7 API
This adds both a compile time check for the SDK version being
compiled against, as well as a runtime check in the case the
resulting binary is run against an older SDK.
https://bugzilla.gnome.org/show_bug.cgi?id=735054
Lapo Calamandrei [Mon, 29 Sep 2014 18:11:49 +0000 (20:11 +0200)]
Adwaita: draw the trough on progressbars in treeviews
See https://bugzilla.gnome.org/show_bug.cgi?id=737517
Lapo Calamandrei [Fri, 26 Sep 2014 15:05:17 +0000 (17:05 +0200)]
Adwaita: make links readable in the dark variant
And fix the messy style we have for *:link in the process.
https://bugzilla.gnome.org/show_bug.cgi?id=737386
Daniel Mustieles [Mon, 29 Sep 2014 17:22:20 +0000 (19:22 +0200)]
Updated Spanish translation
Carlos Garnacho [Mon, 29 Sep 2014 13:35:20 +0000 (15:35 +0200)]
gesture: Document pitfalls on foreign gesture state changes
Add some docs/example about the possible event handling ordering issues
that may appear on GtkGesture::begin between multiple gesture groups.
Mostly relevant for state changes.
Jakub Steiner [Mon, 29 Sep 2014 12:07:10 +0000 (14:07 +0200)]
Adwaita: provide simple guidelines for theming
- Some simple instructions for future SASS/ruby lovers
Jakub Steiner [Fri, 26 Sep 2014 14:33:20 +0000 (16:33 +0200)]
depend on particular version of sass
Rui Matos [Thu, 5 Dec 2013 20:35:36 +0000 (21:35 +0100)]
GtkFontButton: Make sure the dialog isn't destroyed on delete-event
The remaining code assumes that the dialog doesn't get destroyed, but
it actually does on delete-event.
In particular, the filter function and the preview text are lost as
soon as the dialog is created and thus when we create a new dialog we
don't have those properties to set on it anymore.
https://bugzilla.gnome.org/show_bug.cgi?id=719936
Pierre-Yves Luyten [Wed, 27 Aug 2014 21:14:15 +0000 (23:14 +0200)]
gdk_rgba_parse : do not segfault on null string
Matthias Clasen [Sun, 28 Sep 2014 15:42:28 +0000 (11:42 -0400)]
Revert "Make Ctrl-u and Ctrl-k work in GtkTextView too"
This reverts commit
5744bb3cf16cabfe4ee4677c7250ee8f90550a37.
This causes conflicts with already existing shortcuts e.g.
in gedit.
Rūdolfs Mazurs [Sun, 28 Sep 2014 09:35:00 +0000 (12:35 +0300)]
Updated Latvian translation
Tom Tryfonidis [Sat, 27 Sep 2014 10:24:52 +0000 (13:24 +0300)]
Updated Greek translation
Matthias Clasen [Sat, 27 Sep 2014 03:29:38 +0000 (23:29 -0400)]
Add a test for GtkBuilder typename-mangling
This test makes sure that out heuristic for finding
get_type functions works as expected.
https://bugzilla.gnome.org/show_bug.cgi?id=635258
Matthias Clasen [Sat, 27 Sep 2014 03:28:55 +0000 (23:28 -0400)]
Factor out a function
Factor out the typename-to-get-type mangling as a separate
function, for easier testing.
Also fix some cases where it doesn't, currently, like
GString -> g_string_get_type and
GdkRGB -> gdk_rgb_get_type
Matthias Clasen [Sat, 27 Sep 2014 02:37:21 +0000 (22:37 -0400)]
GtkBuilder: Mention more error domains
This has been requested in
https://bugzilla.gnome.org/show_bug.cgi?id=708206
Matthias Clasen [Sat, 27 Sep 2014 02:30:20 +0000 (22:30 -0400)]
Typo fix
Matthias Clasen [Sat, 27 Sep 2014 02:21:11 +0000 (22:21 -0400)]
GtkRange: Fix an event propagation issue
The scale in the selectable listbox in page 2 of gtk3-widget-factory
has the flaw that the row is getting selected even when one only
interacts with the scale - unlike e.g. the checkbutton and button
further down in the listbox.
The problem is that GtkRange is trying to claim the sequence for
the drag gesture from the ::pressed handler of a multipress
gesture. Since the drag gesture hasn't seen the sequence at this
point, that is ineffective.
The fix here is to rearrange the gestures so that the multipress
gesture sees the sequence before the drag gesture, and then
claim the sequence from the ::drag-begin handler.
Matthias Clasen [Fri, 26 Sep 2014 23:24:00 +0000 (19:24 -0400)]
Trivial: reword docs a bit
Matthias Clasen [Fri, 26 Sep 2014 23:18:57 +0000 (19:18 -0400)]
GtkRange: claim sequence when popping up menu
This was clearly an oversight - the function claims the sequence
at the end, and for the popup menu case, we have an early exit
that misses this.
Matthias Clasen [Fri, 26 Sep 2014 22:08:46 +0000 (18:08 -0400)]
Add a style class to fullscreened windows
This will let us tweak stuff that gets shown in fullscreen windows,
https://bugzilla.gnome.org/show_bug.cgi?id=654051
Matthias Clasen [Fri, 26 Sep 2014 22:00:19 +0000 (18:00 -0400)]
Fix a memory leak in gtk_test_find_label
Pointed out by Garrett Regier in
https://bugzilla.gnome.org/show_bug.cgi?id=737439
Matthias Clasen [Fri, 26 Sep 2014 21:53:07 +0000 (17:53 -0400)]
Make Ctrl-u and Ctrl-k work in GtkTextView too
It doesn't make sense to have them work in entries, but not here.
Matthias Clasen [Fri, 26 Sep 2014 15:15:25 +0000 (11:15 -0400)]
inspector: Drop an unused variable
Matthias Clasen [Fri, 26 Sep 2014 15:14:28 +0000 (11:14 -0400)]
entry: Revisit Ctrl-u one more time
Add a Ctrl-k binding too, and make them match their traditional
commandline meaning or 'erase line to the beginning/end'.
Matthias Clasen [Fri, 26 Sep 2014 14:29:10 +0000 (10:29 -0400)]
GtkEntry: Add a key binding for clearing the entry
Ctrl-u is a fine, well-established keybinding for this purpose,
lets just use it.
Matthias Clasen [Fri, 26 Sep 2014 13:49:47 +0000 (09:49 -0400)]
inspector: Simplify populating the tree
No need to loop toplevels in two places.
Matthias Clasen [Fri, 26 Sep 2014 13:43:21 +0000 (09:43 -0400)]
inspector: Show the warning dialog without delay
The delay was a mistaken attempt to work around a problem that
is now better understood, see
https://bugzilla.gnome.org/show_bug.cgi?id=735338
Matthias Clasen [Fri, 26 Sep 2014 13:40:30 +0000 (09:40 -0400)]
Remove some redundant code
No need to check the same widget twice in a row for being a window.
Matthias Clasen [Fri, 26 Sep 2014 13:37:28 +0000 (09:37 -0400)]
GtkWindow: improve the inspector keybinding
Binding signals can return a boolean indicating whether they
handled the event. Use that here and return FALSE if the
inspector keybinding is disabled.
Piotr Drąg [Fri, 26 Sep 2014 10:18:29 +0000 (12:18 +0200)]
Updated Polish translation
Matthias Clasen [Fri, 26 Sep 2014 03:57:34 +0000 (23:57 -0400)]
gtk-demo: Don't create 2 main windows
Loading a builder file with a window leaves a ghost behind, since
windows need to be explicitly destroyed. Avoid that by using
gtk_builder_add_objects_from_resource.
Andika Triwidada [Fri, 26 Sep 2014 03:12:08 +0000 (03:12 +0000)]
Updated Indonesian translation
Matthias Clasen [Fri, 26 Sep 2014 03:05:15 +0000 (23:05 -0400)]
inspector: life-cycle fixes
When closing the inspector before the main window, we must take
care to sever all signal connections and weak refs, otherwise
things will go bad when the window is closed later.
Eric Le Bihan [Thu, 25 Sep 2014 08:11:38 +0000 (10:11 +0200)]
Fix testgtk.c when building for Wayland.
Fix wrong usage of GDK_WINDOWING_WAYLAND instead of
GDK_WINDOWING_X11 in test/testgtk.c.
Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
https://bugzilla.gnome.org/show_bug.cgi?id=737363
Carlos Garnacho [Thu, 25 Sep 2014 13:24:46 +0000 (15:24 +0200)]
button: Fix ::clicked emission on touchscreens sending pointer events
When GtkGestureMultiPress::released happens, in_button should be unset
after emitting GtkButton::released, whose default implementation uses it.
Moreover, in_button should only be unset there for real touch events, not
guaranteed to trigger crossing events, as opposed to every pointer/touch
events from touchscreens.
https://bugzilla.gnome.org/show_bug.cgi?id=737297
Matthias Clasen [Thu, 25 Sep 2014 05:26:06 +0000 (01:26 -0400)]
Use titlebar action settings for CSD windows
Instead of hardcoding these actions, consult the settings.
Note that not all of the actions supported by gnome-shell are
implemented here, only maximize, minimize, lower, and menu.
https://bugzilla.gnome.org/show_bug.cgi?id=729782
Matthias Clasen [Thu, 25 Sep 2014 04:47:33 +0000 (00:47 -0400)]
Factor out titlebar click actions
So they can be made configurable.
https://bugzilla.gnome.org/show_bug.cgi?id=729782
Matthias Clasen [Thu, 25 Sep 2014 05:25:49 +0000 (01:25 -0400)]
Implement titlebar action settings for Wayland
https://bugzilla.gnome.org/show_bug.cgi?id=729782
Matthias Clasen [Thu, 25 Sep 2014 05:25:25 +0000 (01:25 -0400)]
Implement titlebar action settings for X11
https://bugzilla.gnome.org/show_bug.cgi?id=729782
Matthias Clasen [Thu, 25 Sep 2014 05:24:44 +0000 (01:24 -0400)]
Add settings for titlebar actions
These match the GSettings that mutter/metacity/gnome-shell have
for this. We change the default for the middle-click action to
none, since lower is just a terrible default.
We're slightly bending the rules here, since we're adding new
settings after .0, but a) it is just barely after .0, and b) settings
are not really application API.
https://bugzilla.gnome.org/show_bug.cgi?id=729782
Balázs Úr [Thu, 25 Sep 2014 16:00:08 +0000 (16:00 +0000)]
Updated Hungarian translation
Stas Solovey [Thu, 25 Sep 2014 11:55:56 +0000 (11:55 +0000)]
Updated Russian translation
Мирослав Николић [Thu, 25 Sep 2014 07:46:30 +0000 (09:46 +0200)]
Updated Serbian translation
Matthias Clasen [Thu, 25 Sep 2014 03:33:23 +0000 (23:33 -0400)]
Make GtkModelButton work with touch
Some recent refactoring changed things so that in_button is no
longer TRUE when released() is called for touch events. As a minimal
fix, let GtkButton do more of the work by chaining up to its
pressed and released handlers, which know how to handle touch
events. This could be further improved by leaving more of the
state handling to GtkButton, like it was done for GtkToggleButton.
Matthias Clasen [Thu, 25 Sep 2014 00:34:16 +0000 (20:34 -0400)]
Improve workarea documentation
Worth mentioning that workarea may not exist, and that we
return the full monitor geometry in that case.
Matthias Clasen [Thu, 25 Sep 2014 00:20:00 +0000 (20:20 -0400)]
x11: Neuter workarea in fullscreen scenarios
If we have a fullscreen window that covers a monitor, desktop
chrome is not relevant for placing of menus and other popups.
Therefore, return the full monitor geometry instead of the
workarea in this case.
https://bugzilla.gnome.org/show_bug.cgi?id=737251
Matthias Clasen [Wed, 24 Sep 2014 23:50:28 +0000 (19:50 -0400)]
Fix comment typo
Мирослав Николић [Wed, 24 Sep 2014 20:08:31 +0000 (22:08 +0200)]
Updated Serbian translation